CLDSRV-886: pass configurable Server response header to Arsenal by tcarmet · Pull Request #6141 · scality/cloudserver

tcarmet · 2026-04-02T22:03:55Z

Read serverHeader from config and call Arsenal's setServerHeader() at startup. Allows deployments to configure the HTTP Server response header value. Default remains 'S3 Server'.

Depends on: scality/Arsenal#2606

bert-e · 2026-04-02T22:03:59Z

Hello tcarmet,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options

name	description	privileged	authored
`/after_pull_request`	Wait for the given pull request id to be merged before continuing with the current one.
`/bypass_author_approval`	Bypass the pull request author's approval	⭐
`/bypass_build_status`	Bypass the build and test status	⭐
`/bypass_commit_size`	Bypass the check on the size of the changeset `TBA`	⭐
`/bypass_incompatible_branch`	Bypass the check on the source branch prefix	⭐
`/bypass_jira_check`	Bypass the Jira issue check	⭐
`/bypass_peer_approval`	Bypass the pull request peers' approval	⭐
`/bypass_leader_approval`	Bypass the pull request leaders' approval	⭐
`/approve`	Instruct Bert-E that the author has approved the pull request.		✍️
`/create_pull_requests`	Allow the creation of integration pull requests.
`/create_integration_branches`	Allow the creation of integration branches.
`/no_octopus`	Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
`/unanimity`	Change review acceptance criteria from `one reviewer at least` to `all reviewers`
`/wait`	Instruct Bert-E not to run until further notice.

Available commands

name	description	privileged
`/help`	Print Bert-E's manual in the pull request.
`/status`	Print Bert-E's current status in the pull request `TBA`
`/clear`	Remove all comments from Bert-E from the history `TBA`
`/retry`	Re-start a fresh build `TBA`
`/build`	Re-start a fresh build `TBA`
`/force_reset`	Delete integration branches & pull requests, and restart merge process from the beginning.
`/reset`	Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

bert-e · 2026-04-02T22:04:05Z

Incorrect fix version

The Fix Version/s in issue CLDSRV-886 contains:

None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

9.2.33
9.3.6
9.4.0

Please check the Fix Version/s of CLDSRV-886, or the target
branch of this pull request.

claude · 2026-04-02T22:05:01Z

package.json

    "@azure/storage-blob": "^12.28.0",
    "@hapi/joi": "^17.1.1",
-    "arsenal": "git+https://github.com/scality/arsenal#8.2.48",
+    "arsenal": "git+https://github.com/scality/arsenal#e9506a3778ec8e9f395e59c3c6dec86b0c23882f",


Arsenal dependency is pinned to a commit hash instead of a tag. Other git-based deps in this file (bucketclient, utapi, etc.) use version tags. This should be updated to the released tag (e.g. 8.2.49) once the Arsenal PR is merged and tagged.

— Claude Code

Complementing what claude said: I recommend creating a separate DROPME commit to reduce the chances to forget about it

claude · 2026-04-02T22:05:05Z

package.json: Arsenal dependency is pinned to a commit hash instead of a version tag. Should be updated to the released tag before merging.

Review by Claude Code

codecov · 2026-04-02T22:08:09Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.20%. Comparing base (c09dc78) to head (34362d9).
⚠️ Report is 7 commits behind head on development/9.2.
✅ All tests successful. No failed tests found.

Additional details and impacted files

Files with missing lines	Coverage Δ
lib/Config.js	`79.40% <100.00%> (+0.02%)`	⬆️
lib/server.js	`79.61% <100.00%> (+0.19%)`	⬆️

... and 1 file with indirect coverage changes

@@                 Coverage Diff                 @@
##           development/9.2    #6141      +/-   ##
===================================================
- Coverage            84.25%   84.20%   -0.05%     
===================================================
  Files                  204      204              
  Lines                13126    13129       +3     
===================================================
- Hits                 11059    11055       -4     
- Misses                2067     2074       +7

Flag	Coverage Δ
file-ft-tests	`67.62% <100.00%> (-0.05%)`	⬇️
kmip-ft-tests	`28.21% <100.00%> (+0.01%)`	⬆️
mongo-v0-ft-tests	`68.86% <100.00%> (-0.05%)`	⬇️
mongo-v1-ft-tests	`68.85% <100.00%> (-0.05%)`	⬇️
multiple-backend	`35.25% <100.00%> (+0.01%)`	⬆️
sur-tests	`35.73% <100.00%> (+0.01%)`	⬆️
sur-tests-inflights	`37.58% <100.00%> (+0.01%)`	⬆️
unit	`69.75% <100.00%> (+<0.01%)`	⬆️
utapi-v2-tests	`34.51% <100.00%> (+0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

jonathan-gramain · 2026-04-02T23:53:01Z

package.json

    "@azure/storage-blob": "^12.28.0",
    "@hapi/joi": "^17.1.1",
-    "arsenal": "git+https://github.com/scality/arsenal#8.2.48",
+    "arsenal": "git+https://github.com/scality/arsenal#e9506a3778ec8e9f395e59c3c6dec86b0c23882f",


Complementing what claude said: I recommend creating a separate DROPME commit to reduce the chances to forget about it

Read `serverHeader` from config and call Arsenal's `setServerHeader()` at startup. Default remains 'S3 Server'.

bert-e · 2026-04-09T17:57:08Z

Incorrect fix version

The Fix Version/s in issue CLDSRV-886 contains:

None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

9.2.35
9.3.7
9.4.0

Please check the Fix Version/s of CLDSRV-886, or the target
branch of this pull request.

claude · 2026-04-09T17:58:25Z

LGTM

Clean, well-scoped change. Arsenal dependency properly pinned to tag 8.2.50. Config default and functional test both look correct.

Review by Claude Code

tcarmet · 2026-04-09T18:12:33Z

/approve

bert-e · 2026-04-09T18:36:39Z

Build failed

The build for commit did not succeed in branch w/9.4/feature/CLDSRV-886-configurable-server-header

The following options are set: approve

bert-e · 2026-04-09T20:47:32Z

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

✔️ development/9.2
✔️ development/9.3
✔️ development/9.4

The following branches will NOT be impacted:

development/7.10
development/7.4
development/7.70
development/8.8
development/9.0
development/9.1

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

Any commit you add on the source branch will trigger a new cycle after the
current queue is merged.
Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

bert-e · 2026-04-09T21:10:33Z

Queue build failed

The corresponding build for the queue failed:

Checkout the status page.
Identify the failing build and review the logs.
If no issue is found, re-run the build.
If an issue is identified, checkout the steps below to remove
the pull request from the queue for further analysis and maybe rebase/merge.

Remove the pull request from the queue

Add a /wait comment on this pull request.
Click on login on the status page.
Go into the manage page.
Find the option called Rebuild the queue and click on it.
Bert-E will loop again on all pull requests to put the valid ones
in the queue again, while skipping the one with the /wait comment.
Wait for the new queue to merge, then merge/rebase your pull request
with the latest changes to then work on a proper fix.
Once the issue is fixed, delete the /wait comment and
follow the usual process to merge the pull request.

bert-e · 2026-04-09T21:31:47Z

I have successfully merged the changeset of this pull request
into targetted development branches:

✔️ development/9.2
✔️ development/9.3
✔️ development/9.4

The following branches have NOT changed:

development/7.10
development/7.4
development/7.70
development/8.8
development/9.0
development/9.1

Please check the status of the associated issue CLDSRV-886.

Goodbye tcarmet.

claude bot reviewed Apr 2, 2026

View reviewed changes

jonathan-gramain approved these changes Apr 2, 2026

View reviewed changes

BourgoisMickael approved these changes Apr 3, 2026

View reviewed changes

CLDSRV-886: pass configurable Server response header to Arsenal

34362d9

Read `serverHeader` from config and call Arsenal's `setServerHeader()` at startup. Default remains 'S3 Server'.

tcarmet force-pushed the feature/CLDSRV-886-configurable-server-header branch from b5f2146 to 34362d9 Compare April 9, 2026 17:57

bert-e merged commit bd2bcca into development/9.2 Apr 9, 2026
30 checks passed

bert-e deleted the feature/CLDSRV-886-configurable-server-header branch April 9, 2026 21:31

Conversation

tcarmet commented Apr 2, 2026

Uh oh!

bert-e commented Apr 2, 2026

Hello tcarmet,

Uh oh!

bert-e commented Apr 2, 2026

Incorrect fix version

Uh oh!

claude bot Apr 2, 2026

Choose a reason for hiding this comment

Uh oh!

jonathan-gramain Apr 2, 2026

Choose a reason for hiding this comment

Uh oh!

claude bot commented Apr 2, 2026

Uh oh!

codecov bot commented Apr 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

jonathan-gramain Apr 2, 2026

Choose a reason for hiding this comment

Uh oh!

bert-e commented Apr 9, 2026

Incorrect fix version

Uh oh!

claude bot commented Apr 9, 2026

Uh oh!

tcarmet commented Apr 9, 2026

Uh oh!

bert-e commented Apr 9, 2026

Build failed

Uh oh!

bert-e commented Apr 9, 2026

In the queue

Uh oh!

bert-e commented Apr 9, 2026

Queue build failed

Uh oh!

bert-e commented Apr 9, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codecov bot commented Apr 2, 2026 •

edited

Loading